fix: Include text to set/update photo#9186
Conversation
|
Should we restrict showing this to people with some Role? (I still think we should move to gravatar or the like rather than host our own pictures fwiw) |
|
Do we need to discuss gravatar in tools-discuss, or could I just start on a PR to support it?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9186 +/- ##
==========================================
- Coverage 88.74% 88.74% -0.01%
==========================================
Files 321 320 -1
Lines 41853 41656 -197
==========================================
- Hits 37144 36969 -175
+ Misses 4709 4687 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
we have discussed it several times already. It's better done as a tools call topic |
|
I know we have talked about it a lot, I was asking if we have consensus. I'll take your comment as "no" So can we put it on the agenda to get a decision? |
|
I agree that showing the text if the person has a role is the right trade-off of convenience vs load-on-secretariat, so this is a fix and Gravatar is a separate future item. |
This could be the only fix that #2209 (created 2017) is going to get, but I didn't mark it as fixes it.
This PR adds "Email support@ietf.org to update your picture", whether or not there is a photo available.