chore(deps): bump to fixed django-celery-beat#8896
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom May 13, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8896 +/- ##
=======================================
Coverage 88.79% 88.79%
=======================================
Files 314 314
Lines 41402 41402
=======================================
Hits 36764 36764
Misses 4638 4638 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjsparks
approved these changes
May 13, 2025
Member
|
Lets take this opportunity to make the move to doing things in UTC stick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
django-celery-beat 2.8.1 is out with the fix for the time zone issue. We could fall back to >= 2.3.0 because they've yanked the broken release, but I don't see any reason to allow the old versions.
Should be safe to install this immediately since they're all currently in UTC. We can later test that schedules in non-UTC time zones do in fact run, then convert our schedules back to America/Los_Angeles (if we want to do so).