fix: do not list GMT as a meeting time option (#8507)#8681
fix: do not list GMT as a meeting time option (#8507)#8681rjsparks merged 6 commits intoietf-tools:mainfrom
Conversation
jennifer-richards
left a comment
There was a problem hiding this comment.
This looks good, but we should have a migration to update meetings currently using GMT to use UTC instead. I think that just needs to run Meeting.objects.filter(time_zone="GMT").update(time_zone="UTC").
|
We'll add the migration - but it won't be in this week's release. |
|
Ok. Can do it next week, but please feel free to make the change if it needs to be sooner than that. |
jennifer-richards
left a comment
There was a problem hiding this comment.
Added the migration
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8681 +/- ##
==========================================
- Coverage 88.71% 88.70% -0.01%
==========================================
Files 320 320
Lines 41793 41787 -6
==========================================
- Hits 37078 37069 -9
- Misses 4715 4718 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jennifer-richards thanks. |
|
@bkmgit You're welcome, and thank you for the PR! |
# Conflicts: # ietf/meeting/models.py
Fixes #8507