Closed
Conversation
Member
Author
|
OBE - going in a different direction because the monitoring interface is not a good match for a general purpose API approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a set of endpoints at
/api/core/monitoring/<flavor>/to allow various types of monitoring to be served.Considered using a viewset but since this is really not a resource-oriented endpoint, it was cleaner to implement it as a standalone
APIView. I've put it in the same URL prefix-space that the (commented-out)core_Routeruses because it's part of the same API. This means collisions between the router and the explicit route are possible, but I don't think this will be a big issue.Draft PR for a monitoring API using django-rest-framework. This is as much for discussion as actual merging.