fix: keep the ftp dir in sync when the datatracker creates artifacts#8401
Merged
rjsparks merged 7 commits intoietf-tools:mainfrom Jan 9, 2025
Merged
fix: keep the ftp dir in sync when the datatracker creates artifacts#8401rjsparks merged 7 commits intoietf-tools:mainfrom
rjsparks merged 7 commits intoietf-tools:mainfrom
Conversation
This commit has no tests :(. There aren't tests of this yang scaffolding to add to. Adding a set of tests should be an independent larger effort.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8401 +/- ##
==========================================
- Coverage 88.81% 88.80% -0.02%
==========================================
Files 312 312
Lines 40876 40888 +12
==========================================
+ Hits 36304 36309 +5
- Misses 4572 4579 +7 ☔ View full report in Codecov by Sentry. |
jennifer-richards
approved these changes
Jan 9, 2025
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
Looks like it does the advertised things to me.
One question about whether the underlying behavior in the yang checker is good practice, but that's more of an aside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.