chore: remove single-use repair_dead_on_expire task#8348
Merged
rjsparks merged 3 commits intoietf-tools:mainfrom Dec 20, 2024
Merged
chore: remove single-use repair_dead_on_expire task#8348rjsparks merged 3 commits intoietf-tools:mainfrom
rjsparks merged 3 commits intoietf-tools:mainfrom
Conversation
jennifer-richards
requested changes
Dec 18, 2024
Member
jennifer-richards
left a comment
jennifer-richards
left a comment
There was a problem hiding this comment.
Should also remove the repair_dead_on_expire() function from expire.py I think?
Member
Author
|
unsaved buffer issue 😊 |
jennifer-richards
previously approved these changes
Dec 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8348 +/- ##
==========================================
+ Coverage 88.71% 88.80% +0.08%
==========================================
Files 310 312 +2
Lines 40882 40852 -30
==========================================
+ Hits 36270 36280 +10
+ Misses 4612 4572 -40 ☔ View full report in Codecov by Sentry. |
jennifer-richards
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.