Skip to content

feat: copy the 1wg files to so... many... places...#8347

Merged
rjsparks merged 2 commits intoietf-tools:mainfrom
rjsparks:one_star_review
Dec 19, 2024
Merged

feat: copy the 1wg files to so... many... places...#8347
rjsparks merged 2 commits intoietf-tools:mainfrom
rjsparks:one_star_review

Conversation

@rjsparks
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.81%. Comparing base (def346e) to head (72438a2).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
ietf/group/tasks.py 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8347      +/-   ##
==========================================
+ Coverage   88.71%   88.81%   +0.09%     
==========================================
  Files         310      312       +2     
  Lines       40882    40877       -5     
==========================================
+ Hits        36270    36305      +35     
+ Misses       4612     4572      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this were likely to be long-lived, I'd prefer refactoring CHARTER_COPY_PATH as a list. However, as I don't think that's true and we want to encourage adding more dests, this is fine.

@rjsparks
Copy link
Member Author

rjsparks commented Dec 19, 2024

and we want to encourage adding more dests

🕶️

If ... refactoring ... list ...

That's the refactor I started down that led to me asking about typechecking iterables, but we would have to gut the current implemenation of the utility that creates temporary directories at settings names to make that work.

I'm still contemplating creating a new file/class to handle external persistence and isolate all the concerns there, at which point the structure of the relevant settings could be entirely reconsidered.

In any case, when we stop having directories, the tmp directory solution in the utility will be obviated.

@rjsparks rjsparks merged commit fdd3783 into ietf-tools:main Dec 19, 2024
8 checks passed
@rjsparks rjsparks deleted the one_star_review branch December 19, 2024 18:06
@jennifer-richards
Copy link
Member

and we want to encourage adding more dests

🕶️

Oops, I left out the "don't"

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants