feat: copy the 1wg files to so... many... places...#8347
feat: copy the 1wg files to so... many... places...#8347rjsparks merged 2 commits intoietf-tools:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8347 +/- ##
==========================================
+ Coverage 88.71% 88.81% +0.09%
==========================================
Files 310 312 +2
Lines 40882 40877 -5
==========================================
+ Hits 36270 36305 +35
+ Misses 4612 4572 -40 ☔ View full report in Codecov by Sentry. |
jennifer-richards
left a comment
There was a problem hiding this comment.
If this were likely to be long-lived, I'd prefer refactoring CHARTER_COPY_PATH as a list. However, as I don't think that's true and we want to encourage adding more dests, this is fine.
🕶️
That's the refactor I started down that led to me asking about typechecking iterables, but we would have to gut the current implemenation of the utility that creates temporary directories at settings names to make that work. I'm still contemplating creating a new file/class to handle external persistence and isolate all the concerns there, at which point the structure of the relevant settings could be entirely reconsidered. In any case, when we stop having directories, the tmp directory solution in the utility will be obviated. |
Oops, I left out the "don't" |
No description provided.