Skip to content

fix: drop, not bounce, uninteresting ipr emails#8057

Merged
rjsparks merged 3 commits intoietf-tools:mainfrom
jennifer-richards:ignore-base-ipr-address
Oct 17, 2024
Merged

fix: drop, not bounce, uninteresting ipr emails#8057
rjsparks merged 3 commits intoietf-tools:mainfrom
jennifer-richards:ignore-base-ipr-address

Conversation

@jennifer-richards
Copy link
Member

This silently drops (but logs) mail to ietf-ipr@ or with other badly formed addresses that we won't see in a well-configured environment.

Still bounces things that look like ietf-ipr+<identifier>@ if <identifier> could possibly be a valid identifier but does not match known identifiers, or if it fails to process the incoming message.

@rjsparks rjsparks merged commit 9c56ba9 into ietf-tools:main Oct 17, 2024
@jennifer-richards jennifer-richards deleted the ignore-base-ipr-address branch October 17, 2024 21:23
@codecov
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.92%. Comparing base (c7f6bde) to head (a164a03).
Report is 105 commits behind head on main.

Files with missing lines Patch % Lines
ietf/ipr/mail.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8057      +/-   ##
==========================================
+ Coverage   88.78%   88.92%   +0.13%     
==========================================
  Files         296      304       +8     
  Lines       41320    41281      -39     
==========================================
+ Hits        36687    36710      +23     
+ Misses       4633     4571      -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants