fix: Dark mode bug, pinia store reset across Vite entry points#7851
Merged
rjsparks merged 1 commit intoietf-tools:mainfrom Aug 23, 2024
Merged
fix: Dark mode bug, pinia store reset across Vite entry points#7851rjsparks merged 1 commit intoietf-tools:mainfrom
rjsparks merged 1 commit intoietf-tools:mainfrom
Conversation
NGPixel
approved these changes
Aug 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7851 +/- ##
========================================
Coverage 88.78% 88.78%
========================================
Files 296 303 +7
Lines 41320 41422 +102
========================================
+ Hits 36687 36778 +91
- Misses 4633 4644 +11 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IETF meeting agenda's dark mode is broken in some configurations and it looks like this:
The bug is caused by not setting
theme-darkCSS class on the<body>.That's caused by the Pinia store
themevariable being correctly set to'dark'but then incorrectly set tonull.That was caused by two Vite entry points (
main.jsandembedded.js) both callingcreatePinia()which seems to reset the Pinia store state, restoring the theme to the defaultnullwhich broke dark mode.Fixed version: