feat: Unify slide upload and proposal#7787
Merged
rjsparks merged 6 commits intoietf-tools:mainfrom Aug 6, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7787 +/- ##
==========================================
- Coverage 88.78% 88.78% -0.01%
==========================================
Files 296 296
Lines 41320 41322 +2
==========================================
+ Hits 36687 36688 +1
- Misses 4633 4634 +1 ☔ View full report in Codecov by Sentry. |
rjsparks
reviewed
Aug 5, 2024
rjsparks
previously approved these changes
Aug 5, 2024
jennifer-richards
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the propose_session_slides page, URL, and view function and merges them into upload_session_slides. It adds a checkbox, visible to chairs, allowing them to propose, rather than automatically approve, slides they are submitting.
Fixes #7705
Fixes #7178
The tests still have separate test_upload_slides and test_propose_session_slides functions. Some of this may be redundant, but I thought it better to do possibly overtest. Perhaps the tests should be combined as well.