Skip to content

fix: use BOF states in concluded_groups()#7771

Merged
rjsparks merged 3 commits intoietf-tools:mainfrom
jennifer-richards:concluded-bofs
Aug 5, 2024
Merged

fix: use BOF states in concluded_groups()#7771
rjsparks merged 3 commits intoietf-tools:mainfrom
jennifer-richards:concluded-bofs

Conversation

@jennifer-richards
Copy link
Member

@jennifer-richards jennifer-richards commented Jul 31, 2024

Fixes #7770 (though database cleanup will also be needed).

This uses ChangeStateGroupEvent states "bof" and "bof-conc" instead of "active" and "concluded" when displaying BOFs on the concluded_groups() view.

This leads to quite a few changes because there seem to be a number of data quality problems. Some that I've noticed:

  • aggsrv has no concluded date because its history entry is a GroupEvent rather than a ChangeStateGroupEvent
  • netgraph (and other older groups) have ChangeStateGroupEvent records with "active" state rather than "bof"
  • ietfgrow has only a "conclude" event
  • many groups have only a concluded date

These could be cleaned up in the database, but I think this
change does the right thing for the existing data.
@codecov
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.77%. Comparing base (c7f6bde) to head (921a928).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7771      +/-   ##
==========================================
- Coverage   88.78%   88.77%   -0.01%     
==========================================
  Files         296      296              
  Lines       41320    41337      +17     
==========================================
+ Hits        36687    36698      +11     
- Misses       4633     4639       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jennifer-richards jennifer-richards marked this pull request as ready for review August 1, 2024 19:27
@rjsparks rjsparks merged commit 16ac73d into ietf-tools:main Aug 5, 2024
@jennifer-richards jennifer-richards deleted the concluded-bofs branch August 5, 2024 18:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BOF dates inconsistent / absent on concluded groups page

2 participants