fix: better handle "entered" agendas#7721
Merged
rjsparks merged 2 commits intoietf-tools:mainfrom Aug 7, 2024
Merged
Conversation
The open method is specific to Django's uploaded file classes, where it just calls seek(0)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7721 +/- ##
==========================================
- Coverage 88.79% 88.78% -0.01%
==========================================
Files 296 296
Lines 41319 41321 +2
==========================================
Hits 36688 36688
- Misses 4631 4633 +2 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7703
The
handle_upload_file()is still a bit of a mess, but I think this is an incremental improvement.