feat: share precomputed agenda data with agenda.ics#10356
Open
jennifer-richards wants to merge 16 commits intoietf-tools:mainfrom
Open
feat: share precomputed agenda data with agenda.ics#10356jennifer-richards wants to merge 16 commits intoietf-tools:mainfrom
jennifer-richards wants to merge 16 commits intoietf-tools:mainfrom
Conversation
Also changes a log msg so it won't contain "None" awkwardly
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10356 +/- ##
==========================================
- Coverage 88.38% 88.37% -0.02%
==========================================
Files 325 325
Lines 43525 43638 +113
==========================================
+ Hits 38470 38563 +93
- Misses 5055 5075 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speeds up the agenda.ics endpoints to near instant. Assuming we keep the caches warm as intended, it will also speed up all agenda page loads.
agenda_ical()and its helpers to use the same precomputed data that is supplied to the agenda-neue frontend.agenda_data_refreshtoagenda_data_refresh_task(keeps/deprecates old task until we deploy and update our config to use the new name)I propose that we continue refreshing the agenda data for the "current" meeting every 5 minutes but only weekly for other meetings. That was assumed in choosing the new constants in
settings.py. This does not add a mechanism for invalidating the cache dynamically if the agenda is changed. A change like that will need a manual cache refresh if waiting for the next regular refresh is not acceptable.Note: The cache is kept in memcache. Data for each meeting is 200-300 kB, so it fits well within memcache's size limit. Restarting memcached will lose cached data, though. I think this is acceptable because memcached restarts are rare and the cache will recover on its own as requests come in, usually with at most one slow request per meeting.