Skip to content

fix: restrict rfc bulkload to those with a Document object#10289

Merged
rjsparks merged 3 commits intoietf-tools:mainfrom
rjsparks:skip_non_rfc_bulkload
Jan 21, 2026
Merged

fix: restrict rfc bulkload to those with a Document object#10289
rjsparks merged 3 commits intoietf-tools:mainfrom
rjsparks:skip_non_rfc_bulkload

Conversation

@rjsparks
Copy link
Member

No description provided.

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

One thought inline in case it resonates, but if the doc names are corrupted in a way that it matters then we're in deeper trouble already.

Comment on lines +44 to +45
doc_name=f"rfc{num}",
doc_rev=None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you wanted to be paranoid, you could iterate over Documents instead of numbers and use doc.name and doc.rev here. I think the data are clean in this regard, though.

@rjsparks rjsparks merged commit 4ff4805 into ietf-tools:main Jan 21, 2026
8 checks passed
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.39%. Comparing base (37888b3) to head (7772091).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
ietf/sync/utils.py 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10289      +/-   ##
==========================================
- Coverage   88.39%   88.39%   -0.01%     
==========================================
  Files         325      325              
  Lines       43453    43459       +6     
==========================================
+ Hits        38410    38415       +5     
- Misses       5043     5044       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants