fix: restrict rfc bulkload to those with a Document object#10289
Merged
rjsparks merged 3 commits intoietf-tools:mainfrom Jan 21, 2026
Merged
fix: restrict rfc bulkload to those with a Document object#10289rjsparks merged 3 commits intoietf-tools:mainfrom
rjsparks merged 3 commits intoietf-tools:mainfrom
Conversation
jennifer-richards
approved these changes
Jan 21, 2026
Member
jennifer-richards
left a comment
There was a problem hiding this comment.
lgtm
One thought inline in case it resonates, but if the doc names are corrupted in a way that it matters then we're in deeper trouble already.
Comment on lines
+44
to
+45
| doc_name=f"rfc{num}", | ||
| doc_rev=None, |
Member
There was a problem hiding this comment.
If you wanted to be paranoid, you could iterate over Documents instead of numbers and use doc.name and doc.rev here. I think the data are clean in this regard, though.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10289 +/- ##
==========================================
- Coverage 88.39% 88.39% -0.01%
==========================================
Files 325 325
Lines 43453 43459 +6
==========================================
+ Hits 38410 38415 +5
- Misses 5043 5044 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.