test: more robust URL coverage; improve badly formed test#10270
Merged
rjsparks merged 3 commits intoietf-tools:mainfrom Jan 16, 2026
Merged
test: more robust URL coverage; improve badly formed test#10270rjsparks merged 3 commits intoietf-tools:mainfrom
rjsparks merged 3 commits intoietf-tools:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10270 +/- ##
=======================================
Coverage 88.40% 88.41%
=======================================
Files 324 324
Lines 43344 43344
=======================================
+ Hits 38318 38322 +4
+ Misses 5026 5022 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rjsparks
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main work here is to use Django's
resolve()rather than applying our own regex matching to our url coverage test. This ensures that we're accounting for coverage that agrees with what Django is doing. Motivated becausepathURL patterns handle end-of-string anchors in a way that the old regex code does not account for, so overlapping URLs may be accounted incorrectly. That is, two patterns^api/purple/rfc/publish/^api/purple/rfc/publish/files/may both match the URL
api/purple/rfc/publish/files/because the regexes don't have a trailing$. Thepathgearing applies the$, but our code did not.Also fixes a random other test that was passing, but using unrealistic data.