Skip to content

feat: rsync rfc content, store in blob, rebuild references #10255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rjsparks merged 27 commits into from
Jan 16, 2026
Merged

feat: rsync rfc content, store in blob, rebuild references #10255

rjsparks merged 27 commits into from
Jan 16, 2026
+338 −19

Conversation

@rjsparks
Copy link
Member

@rjsparks rjsparks commented Jan 13, 2026

No description provided.

jennifer-richards
jennifer-richards requested changes Jan 13, 2026
View reviewed changes
Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor nits. One high-level comment: I assume it's intentional that the prerelease/ files are stashed in the blob store but not added to datatracker's own filesystem. The RPC also publishes a .json that datatracker ignores afaik, but should be treated as a publication artifact.

@rjsparks
Copy link
Member Author

rjsparks commented Jan 14, 2026 •
edited
Loading

Yes, it's intentional that notprepped isn't landing in the dt filesystem.
We'll be working on where the computation of the .json happens.
I was wrong on both counts - the current system has both the notprepped and the json in the ::rfc rsync module.
I'll put them both in the fs as I'm doing the other files.

rjsparks added 21 commits January 14, 2026 09:50
@rjsparks
fix: use list for typing rather than List
b944af5
@rjsparks
fix: string formatting
e76b6fb
@rjsparks
fix: generalize error string when there are no files to parse
350cbff
@rjsparks
fix: use delete_on_close with NamedTemporaryFile
50f7b46
@rjsparks
fix: mtime is less distracting than m_time
98922b8
@rjsparks
fix: store the notprepped file on the fs
d398c9f
@rjsparks
fix: typo
cf8e25b
@rjsparks
fix: fetch json, remove unneeded unlink
451d50f
@rjsparks
chore: ruff
98a5995
@rjsparks
fix: use list for typing
eb9e458
@rjsparks
fix: typo
bb123b5
@rjsparks
feat: bulk load rfcs into blob storage
814b147
@rjsparks
fix: restrict the rsync_helper to rsync
cb023ad
@rjsparks
test: test ietf.sync.utils
4a45d4f
@rjsparks
chore: honor typing choices
df0afbf
@rjsparks
test: sync task tests
1f7ba5e
@rjsparks
refactor: isolate the rsync from-file construction and test it
897fb33
@rjsparks
chore: ruff
f1f89ca
@rjsparks
ci: merge ietf-tools/main
56e6499
@rjsparks
fix: reflect current changes in older test
22c7169
@rjsparks
fix: address incorrect test assumption
09324c9
jennifer-richards
jennifer-richards requested changes Jan 15, 2026
View reviewed changes
Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits and a place where the test could be tightened (but, as noted inline, it's not clear to me it's worth the effort on that)

@rjsparks rjsparks merged commit 337a231 into main Jan 16, 2026
13 of 14 checks passed
@rjsparks rjsparks deleted the feat/rfcbuckets branch January 16, 2026 20:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jennifer-richards jennifer-richards jennifer-richards approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rjsparks @jennifer-richards