Skip to content

feat: provide link to detailed submission status page for submission api #10233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjsparks merged 2 commits into from
Jan 9, 2026
+12 −1
Merged

feat: provide link to detailed submission status page for submission api #10233

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a46d35d
feat: include link to detailed submission status page for submission api
Jan 8, 2026
ec03c30
chore: rename endpoint to submission_url
Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ietf/submit/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2404,7 +2404,7 @@ def test_upload_draft(self):
response = r.json()
self.assertCountEqual(
response.keys(),
['id', 'name', 'rev', 'status_url'],
['id', 'name', 'rev', 'status_url', 'submission_status_url'],
)
submission_id = int(response['id'])
self.assertEqual(response['name'], 'draft-somebody-test')
Expand All @@ -2416,6 +2416,13 @@ def test_upload_draft(self):
kwargs={'submission_id': submission_id},
),
)
self.assertEqual(
response['submission_status_url'],
'https://datatracker.example.com' + urlreverse(
'ietf.submit.views.submission_status',
kwargs={'submission_id': submission_id},
)
)
self.assertEqual(mock_task.delay.call_count, 1)
self.assertEqual(mock_task.delay.call_args.args, (submission_id,))
submission = Submission.objects.get(pk=submission_id)
Expand Down
4 changes: 4 additions & 0 deletions ietf/submit/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@ def err(code, error, messages=None):
settings.IDTRACKER_BASE_URL,
urlreverse(api_submission_status, kwargs={'submission_id': submission.pk}),
),
'submission_status_url': urljoin(
Copy link
Member

@jennifer-richards jennifer-richards Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little worried that having both status_url and submission_status_url as fields in the response is potentially confusing. My first reaction is to suggest friendly_status_url or just submission_url. Don't know if @rjsparks has any thoughts?

settings.IDTRACKER_BASE_URL,
urlreverse("ietf.submit.views.submission_status", kwargs={'submission_id': submission.pk}),
),
}
)
else:
Expand Down
Loading