Is it ready to be included in homebrew cask?

[szw0407]

If so, perhaps we can try creating a Tap or PR to Homebrew-cask.

[idawnlight]

You may have a try, but Homebrew Casks has a notability requirement, and I'm not sure if this project currently meets the requirements:

App is too obscure. Examples:

• An app from a code repository that is not notable enough (under 30 forks, 30 watchers, 75 stars).
• For self-submitted casks where the PR author is the owner of the repository, higher thresholds apply (under 90 forks, 90 watchers, 225 stars).

[ChiahongHong]

Hi @idawnlight

Since the homebrew review may not pass, I thought that before then, if you is willing, you could use my repo as a template to create a official homebrew tap. I think it would be best for the original author to maintain the homebrew tap.

Once an official homebrew tap is created, I will archive my repo:
https://github.com/ChiahongHong/homebrew-shichizip

You can try:

brew tap ChiahongHong/shichizip
brew install --cask shichizip

To revert:

brew untap ChiahongHong/shichizip

[idawnlight]

Since the homebrew review may not pass, I thought that before then, if you is willing, you could use my repo as a template to create a official homebrew tap. I think it would be best for the original author to maintain the homebrew tap.

Thank you! This looks like a high-quality cask definition to me.

By the way, I checked how Homebrew determines if a repo is notable enough, and it seems that meeting any of their three requirements is enough. If you're up for it, you might want to consider submitting this to the official casks and see if it gets accepted, as the thresholds are higher if I submit it myself. 👀

[ChiahongHong]

@idawnlight I can help submit the cask, no problem XD

But I’ll need your help updating the description, since it was blocked by the checker.
What do you think we should change it to?

$ brew style --fix shichizip

Taps/chiahonghong/homebrew-shichizip/Casks/shichizip.rb:10:39: C: Cask/Desc: Description shouldn't contain the platform.
  desc "7-Zip derivative intended for macOS"
                                      ^^^^^

1 file inspected, 1 offense detected

[idawnlight]

But I’ll need your help updating the description, since it was blocked by the checker. What do you think we should change it to?

Hmmm, I don't have any better idea either. Maybe a simpler one like 7-Zip derivative GUI?

[ChiahongHong]

Let’s just write it like this for now! You can update it later if you think of something better. I don’t think anyone will really read what the description says anyway XDD

I’ve submitted a new cask PR to homebrew~
Homebrew/homebrew-cask#263599

[ChiahongHong]

Hi @idawnlight
The cask has already been merged!!

[idawnlight]

@ChiahongHong Thank you very much for your efforts! 🎉

[szw0407]

Wow that's amazing!

[szw0407]

Moreover, shall the ZS be included too in the homebrew Tap since I am using this version. I shall help do this if needed.

[szw0407]

ChiahongHong/homebrew-shichizip#1

I have made this PR to the upstream Tap.

Alternatively, please move towards my tap to use it before the upstream accepts it:

brew tap szw0407/shichizip-zs
brew install --cask shichizip-zs

Moreover, the readme is modified and required approval. #27

Thanks!

[idawnlight]

Moreover, shall the ZS be included too in the homebrew Tap since I am using this version. I shall help do this if needed.

Hmmm, I'm not sure if Homebrew would accept a variant cask. MacPorts does support variants though, and it's currently being maintained by @i0ntempest.

And thank you for bringing up another third-party tap. But if necessary I think it would be better to maintain a tap in this repo and integrated with current CI pipelines to prevent possible inconsistency or delays.

[szw0407]

Well, perhaps we can add a hook in this project. The actions in the Tap repos then can be automatically triggered.

[szw0407]

Moreover I wonder if the Tap can be maintained inside the repo directly.