Skip to content

fix: malformed fallback setter method names #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

fix: malformed fallback setter method names #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ members = [".", "./typed-builder-macro"]

[workspace.package]
description = "Compile-time type-checked builder derive"
version = "0.21.0"
version = "0.21.1"
authors = ["IdanArye <[email protected]>", "Chris Morgan <[email protected]>"]
edition = "2021"
license = "MIT OR Apache-2.0"
Expand All @@ -27,4 +27,4 @@ keywords.workspace = true
categories.workspace = true

[dependencies]
typed-builder-macro = { path = "typed-builder-macro", version = "=0.21.0" }
typed-builder-macro = { path = "typed-builder-macro", version = "=0.21.1" }
17 changes: 10 additions & 7 deletions typed-builder-macro/src/struct_info.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@ use proc_macro2::{Ident, Span, TokenStream};
use quote::{format_ident, quote, quote_spanned, ToTokens};
use syn::{parse::Error, parse_quote, punctuated::Punctuated, GenericArgument, ItemFn, Token};

use crate::builder_attr::{IntoSetting, TypeBuilderAttr};
use crate::field_info::FieldInfo;
use crate::mutator::Mutator;
use crate::util::{
empty_type, empty_type_tuple, first_visibility, modify_types_generics_hack, phantom_data_for_generics, public_visibility,
strip_raw_ident_prefix, type_tuple,
use crate::{
builder_attr::{IntoSetting, TypeBuilderAttr},
field_info::FieldInfo,
mutator::Mutator,
util::{
empty_type, empty_type_tuple, first_visibility, modify_types_generics_hack, phantom_data_for_generics, public_visibility,
strip_raw_ident_prefix, type_tuple,
},
};

#[derive(Debug)]
Expand Down Expand Up @@ -305,9 +307,10 @@ impl<'a> StructInfo<'a> {
} else if strip_option.fallback_prefix.is_none() && strip_option.fallback_suffix.is_none() {
None
} else {
let method = strip_raw_ident_prefix(field_name.to_string());
let prefix = strip_option.fallback_prefix.as_deref().unwrap_or_default();
let suffix = strip_option.fallback_suffix.as_deref().unwrap_or_default();
let fallback_name = syn::Ident::new(&format!("{}{}{}", prefix, field_name, suffix), field_name.span());
let fallback_name = syn::Ident::new(&format!("{}{}{}", prefix, method, suffix), field_name.span());
Some((fallback_name, quote!(#field_name: #field_type), quote!(#arg_expr)))
}
});
Expand Down
Loading