Use glutin-winit in integration_opengl example#1689
Closed
ids1024 wants to merge 1 commit intoiced-rs:masterfrom
Closed
Use glutin-winit in integration_opengl example#1689ids1024 wants to merge 1 commit intoiced-rs:masterfrom
glutin-winit in integration_opengl example#1689ids1024 wants to merge 1 commit intoiced-rs:masterfrom
Conversation
Contributor
Author
|
I guess for |
Glutin 0.30 changes the API to not depend on winit, and instead take a raw window handle. `glutin-winit` is a helper to make it a bit easier to create a GL context on top of winit. Things like `iced_winit::conversion::window_event` are problematic here since we end up using a different winit version from `iced_winit`, and that function is quite complicated to duplicate. But we don't need all of it. Duplicating isn't so unreasonable. It's probably expected that integrations of Iced could not rely on conversions from `iced_winit`, since likely use something other than winit to get a window and OpenGL context, and in any case are not using the Iced fork of `winit`.
ids1024
changed the title
glutin-winit in integration_opengl exampleglutin-winit in integration_opengl example
Contributor
Author
|
This seems to be working well now, with some event conversion code copied from An OpenGL integration is expected to be used with things other than |
Member
|
Closing because of #1688 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glutin 0.30 changes the API to not depend on winit, and instead take a raw window handle.
glutin-winitis a helper to make it a bit easier to create a GL context on top of winit.Things like
iced_winit::conversion::window_eventare problematic here since we end up using a different winit version fromiced_winit, and that function is quite complicated to duplicate...