Update dl-iks-classic.md #81
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ingress resources example v1beta1 does not work anymore with the current version of iks deployed in ibm cloud, the changes maded to the yaml file include moving the annotation of kubernetes.io/ingress.class to the spec: section with ingressClassname indented as same level as metadata Also, apiVersion is changed to v1.
What must be peer reviewed?
Every change in the docs must be peer reviewed, unless you are JUST fixing a typo. When you add or change a sentence, you must get a peer review.
If your change is part of a larger overhaul or a bigger change in the docs, you can merge the content to staging without a peer review and inform the peer reviewer once you are done with the change and ready to have it peer reviewed.
Important: Peer reviews do not replace technical reviews. Make sure to have your content reviewed by dev as well to ensure technical accuracy.
What is included in a peer review?
Content:
In Addition, if peer review is done in staging:
**Images: **
What is NOT included in a peer review and must be completed by the writer?