-
Notifications
You must be signed in to change notification settings - Fork 35
V1 merge #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
feat(cosmos): propagate `$chain.env` when calling scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR merges the v1
branch into main
, retaining both Helm charts and the generator in main
while keeping v1
active for ongoing syncs.
- Add shared environment variable includes via two helper templates
- Remove inline environment loops in multiple chain templates
- Bump chart version and expand GitHub workflows to watch the
v1
branch
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
charts/devnet/templates/chains/cosmos/validator.yaml | Include defaultEvnVars /evnVars and clean up old loops |
charts/devnet/templates/chains/cosmos/genesis.yaml | Same environment include adjustments for genesis |
charts/devnet/templates/_helpers.tpl | Define new devnet.evnVars helper |
charts/devnet/Chart.yaml | Bump chart version from 1.8.0 to 1.8.1 |
.github/workflows/* | Add v1 branch to PR triggers in all workflows |
Comments suppressed due to low confidence (2)
starship/charts/devnet/templates/chains/cosmos/validator.yaml:157
- [nitpick] This
echo
prints only a blank line and may have been left in by mistake; consider removing it or adding a descriptive message.
echo
starship/charts/devnet/templates/chains/cosmos/validator.yaml:60
- [nitpick] You repeat the
defaultEvnVars
andevnVars
includes in multiple templates; consider creating a single wrapper helper that inlines both to reduce duplication.
{{ include "devnet.defaultEvnVars" $chain | indent 12 }}
Co-authored-by: Copilot <[email protected]>
feature: ingress grpc
merge v1 into main, we can keep both the helm charts and the generator in main at the same time.
We will additionally keep the v1 branch active and keep merging from time to time.