Close button overlaps with status bar in iPhone X

[annjawn]

The close button is currently overlapping with the status bar in iPhone X which makes it inaccessible so swipe to dismiss is the only thing that works.

[onmyway133]

@annjawn Hi, thanks for reporting the issue. It maybe because we haven't used safe area when doing layout.

[onmyway133]

@annjawn Hi, can you check https://github.com/hyperoslo/Lightbox/releases/tag/2.1.0 ?

[annjawn]

Hi @onmyway133 , yes it's a safe area issue. I've been having a lot of trouble with safe area in my project and had to do multiple workarounds. There are issues with other libs that use controllers like this and I have raised issues and requested PRs with them and you are the only one who responded so fast and fixed it so thank you so much. 😃

[annjawn]

@onmyway133 the latest update (2.1.0) is causing a crash at InfoLabel.swift

Reverted to 2.0.1 and the error was gone but back to the iPhone X layout issue.

[onmyway133]

@annjawn I think this was the problem with truncating text with emoji, however I can't reproduce it. Do you have any detailed steps that I can reproduce ?

[annjawn]

@onmyway133 Hey man. I wasn't able to recreate the issue. BUT, this morning, I cloned your project and ran pod update and after that I noticed that the Infolabel.swift had a few differences than what's on my project. The sample project had this

var truncatedText: String {
        var truncatedText = fullText
        
        guard numberOfLines(fullText) > numberOfVisibleLines else {
            return truncatedText
        }
        
        // Perform quick "rough cut"
        while numberOfLines(truncatedText) > numberOfVisibleLines * 2 {
            truncatedText = String(truncatedText.prefix(truncatedText.count / 2))
        }
        
        // Capture the endIndex of truncatedText before appending ellipsis
        var truncatedTextCursor = truncatedText.endIndex
        
        truncatedText += ellipsis
        
        // Remove characters ahead of ellipsis until the text is the right number of lines
        while numberOfLines(truncatedText) > numberOfVisibleLines {
            // To avoid "Cannot decrement before startIndex"
            guard truncatedTextCursor > truncatedText.startIndex else {
                break
            }
            
            truncatedTextCursor = truncatedText.index(before: truncatedTextCursor)
            truncatedText.remove(at: truncatedTextCursor)
        }
        
        return truncatedText
    }

Where as my project had this

fileprivate var truncatedText: String {
    var truncatedText = fullText

    guard numberOfLines(fullText) > numberOfVisibleLines else {
      return truncatedText
    }

    // Perform quick "rough cut"
    while numberOfLines(truncatedText) > numberOfVisibleLines * 2 {
        truncatedText = String(truncatedText.prefix(truncatedText.count / 2))
    }

    // Capture the endIndex of truncatedText before appending ellipsis
    var truncatedTextCursor = truncatedText.endIndex

    truncatedText += ellipsis

    // Remove characters ahead of ellipsis until the text is the right number of lines
    while numberOfLines(truncatedText) > numberOfVisibleLines {
        truncatedTextCursor = truncatedText.index(before: truncatedTextCursor)
        truncatedText.remove(at: truncatedTextCursor)
    }

    return truncatedText
  }

I am not sure why because the pod is upto date but I took your changes in manually and now it works.

[onmyway133]

@annjawn Hi, it was because of this PR #157 which was just merged into master. We will release new version soon. I will close this for now, as it was originally an issue regarding iPhone X