Fix cargo feature 'dump_on_crash' #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
commented
Nov 21, 2024
ludfjig
force-pushed
the
crashdump
branch
6 times, most recently
from
01523e1 to
9e4a43d
Compare
ludfjig
changed the title
ludfjig
force-pushed
the
crashdump
branch
2 times, most recently
from
cba49da to
9475fd6
Compare
syntactically
previously approved these changes
Nov 25, 2024
syntactically
approved these changes
Nov 26, 2024
ludfjig
force-pushed
the
crashdump
branch
2 times, most recently
from
12e6bda to
91a3294
Compare
danbugs
approved these changes
Nov 26, 2024
…ve logic to its own module Signed-off-by: Ludvig Liljenberg <[email protected]>
…bug_assertions Signed-off-by: Ludvig Liljenberg <[email protected]>
…ug" compiles Signed-off-by: Ludvig Liljenberg <[email protected]>
… log::debug, and alias feature with debug_assertions Signed-off-by: Ludvig Liljenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70. Renames the feature to just "crashdump". Moves it into VirtualCPU::run, so each driver doesn't need to call it. Behavior should be the same: dumps registers,memory_regions and raw memory to file for certain hyperlightexits: mmio, accessviolation, unknown, and errors.
Also changes uses of
crate::debug!macro to explicilty use thecratemodule prefix to distinguish from thelogcrate.