-
Notifications
You must be signed in to change notification settings - Fork 139
Fix Windows build with --no-default-features
#712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think we should strive to set the same registers on all hypervisors, so we don't rely on any inherent defaults of a particular hv. Thoughts?
c8511cc
to
fe110fb
Compare
Probably a good idea—we should also avoid relying on
This is exactly the setup we needed w/o Might be a good work item for #469? |
2c28574
to
85e2184
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I agree that we need a common way of setting the registers for all the Hypervisors, independent of the features enabled.
97b3e43
Signed-off-by: danbugs <[email protected]>
+ on Linux w/o init-paging but some driver Signed-off-by: danbugs <[email protected]>
…ture Signed-off-by: danbugs <[email protected]>
97b3e43
to
27c01ea
Compare
Fixes #685 and updates CI to ensure Windows builds successfully without default features.
Btw, to validate this fix, I tested running Nanvix (which uses
--no-default-features
) on Windows as a guest. This revealed that additional register setup was needed inhyperv_windows.rs
:Limit
parameter for CS to0xFFFF
(required when paging isn't initialized)These changes ensure Windows Hyper-V properly initializes guest VMs that don't use the init-paging feature. Same idea for Linux Hyper-V too.