Switch 'deny' lints to 'warn' #679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
requested review from
danbugs,
dblnz,
devigned,
syntactically,
marosset,
jprendes and
simongdavies
as code owners
ludfjig
added
the
kind/enhancement
… will be caught by clippy regardless in CI Signed-off-by: Ludvig Liljenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These
denylints can be annoying during local development as it prevents your code from compiling while iterating. Switching towarninstead shouldn't have any negative impact on quality, since clippy will still catch all warnings which will still prevent PRs from being merged.I added (back) a compiler error if neither hypervisor feature is enabled, as that is required by a test
just test-compilation-fail. It was removed when in-process mode was added to Linux, but never re-added when in-process mode was removed. I think it's important that this is a compiler error and not a runtime error as Hyperlight is useless without an enabled hypervisor. (At runtime the error would otherwise be surfaced as a NoHypervisorFound error)