gdb: fix issue "Debug not enabled" when gdb feature was enabled
#678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This happened due to a message that was sent from the Hypervisor to the `gdb` thread even if the sandbox had no debug enabled. The transmission failed and returned this error. - The fix checks a condition before sending this signal so that to ensure the sandbox has debugging enabled Signed-off-by: Doru Blânzeanu <[email protected]>
dblnz
requested review from
devigned,
syntactically,
marosset,
jprendes and
simongdavies
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue with the
gdbfeature.NOTE: Additionally, I have modified the
guest-debuggingexample to use two sandboxes(one with debugging enabled and one without) to help find similar issues in the future.Behavior
When the
gdbfeature is turned on forhyperlightand a sandbox is not configured to enable debugging, it receivesDebug not enablederror.Root cause
This happens because of a message that is sent, during the Hypervisor construction phase, from the Hypervisor to the
gdbthread.The problem is that the signal is sent even if the sandbox has no debug enabled.
The transmission fails because there is no
gdbthread to receive it and returns this error.Fix
Add a condition before sending the signal to ensure the sandbox has debugging enabled