Skip to content

Don't log expected error on each guest function call #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

Don't log expected error on each guest function call #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/hyperlight_common/src/flatbuffer_wrappers/guest_error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ impl GuestError {

impl TryFrom<&[u8]> for GuestError {
type Error = Error;
#[cfg_attr(feature = "tracing", instrument(err(Debug), skip_all, parent = Span::current(), level= "Trace"))]
fn try_from(value: &[u8]) -> Result<Self> {
let guest_error_fb = size_prefixed_root::<FbGuestError>(value)
.map_err(|e| anyhow::anyhow!("Error while reading GuestError: {:?}", e))?;
Expand Down
1 change: 0 additions & 1 deletion src/hyperlight_host/src/mem/mgr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,6 @@ impl SandboxMemoryManager<HostSharedMemory> {
}

/// Get the guest error data
#[instrument(err(Debug), skip_all, parent = Span::current(), level= "Trace")]
pub(crate) fn get_guest_error(&mut self) -> Result<GuestError> {
self.shared_mem.try_pop_buffer_into::<GuestError>(
self.layout.output_data_buffer_offset,
Expand Down
1 change: 0 additions & 1 deletion src/hyperlight_host/src/mem/shared_mem.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,6 @@ impl HostSharedMemory {
/// Pops the given given buffer into a `T` and returns it.
/// NOTE! the data must be a size-prefixed flatbuffer, and
/// buffer_start_offset must point to the beginning of the buffer
#[instrument(err(Debug), skip_all, parent = Span::current(), level= "Trace")]
pub fn try_pop_buffer_into<T>(
&mut self,
buffer_start_offset: usize,
Expand Down
Loading