Let windows decide at which address to map shared memory in surrogate process #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
requested review from
danbugs,
dblnz,
devigned,
syntactically,
marosset,
jprendes and
simongdavies
as code owners
ludfjig
commented
Jun 17, 2025
src/hyperlight_host/src/hypervisor/windows_hypervisor_platform.rs
Outdated
Show resolved
Hide resolved
… process Signed-off-by: Ludvig Liljenberg <[email protected]>
simongdavies
approved these changes
Jun 18, 2025
dblnz
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we assumed that the host process's shared memory address is available, which might not always be the case. I believe this is what caused the CI to fail sporadically.
Also removes some fields relating to size/addresses that we don't need
closes #579