Optimize serialization of function calls #444
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
force-pushed
the
avoid_vec_allocation
branch
from
8226520 to
df05f27
Compare
ludfjig
added
kind/enhancement
marosset
previously approved these changes
Apr 30, 2025
ludfjig
commented
Apr 30, 2025
| @@ -288,9 +223,40 @@ impl TryFrom<FunctionCall> for Vec<u8> { | |||
| }, | |||
| ); | |||
| builder.finish_size_prefixed(function_call, None); | |||
| let res = builder.finished_data().to_vec(); | |||
There was a problem hiding this comment.
This to_vec is the clone I was able to avoid, which is the most important part of this PR
simongdavies
previously approved these changes
Apr 30, 2025
…ssary allocations and copies Signed-off-by: Ludvig Liljenberg <[email protected]>
…atures Signed-off-by: Ludvig Liljenberg <[email protected]>
…ight-guest Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
avoid_vec_allocation
branch
from
df05f27 to
9d05679
Compare
dblnz
approved these changes
May 12, 2025
| "Tried to serialize a host function call as a guest function call" | ||
| ); | ||
| } | ||
| FunctionCallType::Guest => {} |
There was a problem hiding this comment.
Nit: maybe move the logic below on the Guest match arm or use an if let FunctionCallType::Host.
|
|
||
| #[cfg_attr(feature = "tracing", instrument(err(Debug), skip_all, parent = Span::current(), level= "Trace"))] | ||
| pub fn validate_host_function_call_buffer(function_call_buffer: &[u8]) -> Result<()> { |
There was a problem hiding this comment.
Maybe I missed it, but where was this function called?
If it wasn't used at all, I am curious how the compiler hasn't warned us.
|
closed in favor of #778 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_vecon the serialized flatbuffer slice. A downside of this is that we expose an implementation detail ("FlatBufferBuilder"), but I think this is acceptable forFunctionCall, and not visible to users anyway.write_guest_function_calltake in aFunctionCallrather than a raw slice.validate_host_function_call_bufferguest_call_*benchmarks shows rougly -6% execution speedup on my local machine, but will depend heavily on the types of function calls and parameters used