[github-actions] Made it so tests also run on intel #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we add intel to benchmarking too? And include them in github release artifacts? |
|
@danbugs when this merges you will need to update the branch protection rules required checks as there are now new checks and some of the existing ones don't exist |
danbugs
force-pushed
the
add-intel-runners-to-build-matrix
branch
from
1019713 to
f060b76
Compare
ludfjig
reviewed
Nov 7, 2024
danbugs
force-pushed
the
add-intel-runners-to-build-matrix
branch
3 times, most recently
from
f060b76 to
7f3d83a
Compare
simongdavies
approved these changes
Nov 7, 2024
auto-merge was automatically disabled
November 7, 2024 21:03
Base branch requires signed commits
danbugs
force-pushed
the
add-intel-runners-to-build-matrix
branch
from
73b5512 to
b0b9e5f
Compare
Note: I only modified the dep_rust matrix which will run the tests to assess differences between amd and intel. In the future, we might want to consider revisiting our matrix setup. Signed-off-by: danbugs <[email protected]>
…rks to release artifacts Signed-off-by: danbugs <[email protected]>
Signed-off-by: danbugs <[email protected]>
Signed-off-by: danbugs <[email protected]>
danbugs
force-pushed
the
add-intel-runners-to-build-matrix
branch
from
b0b9e5f to
2a43eca
Compare
auto-merge was automatically disabled
November 7, 2024 22:07
Base branch requires signed commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I only modified the dep_rust matrix which will run the tests to assess differences between amd and intel. In the future, we might want to consider revisiting our matrix setup.