-
Notifications
You must be signed in to change notification settings - Fork 29
Add component model example and add test in CI #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jsturtevant
merged 2 commits into
hyperlight-dev:main
from
jsturtevant:add-wasi-example
Jun 24, 2025
Merged
Add component model example and add test in CI #73
jsturtevant
merged 2 commits into
hyperlight-dev:main
from
jsturtevant:add-wasi-example
Jun 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
commented
Jun 20, 2025
5d29ba7
to
8920e36
Compare
jsturtevant
commented
Jun 21, 2025
493e9e6
to
0b0d096
Compare
marosset
reviewed
Jun 23, 2025
marosset
reviewed
Jun 23, 2025
marosset
reviewed
Jun 23, 2025
marosset
reviewed
Jun 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for some nits on naming and installing tools in the various just commands.
206d158
to
5e9011a
Compare
marosset
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for making the changes to the just file!
11e7d97
to
af74f30
Compare
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
af74f30
to
fdb6ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially address hyperlight-dev/hyperlight#645
fixes #652
fixes #74
This pull request introduces support for WASI (WebAssembly System Interface) samples in the project. The changes include adding new functionality for compiling and running WASI examples, updating dependencies, and modifying build scripts and documentation to reflect the new features.
Component model example Implementation:
wasi_samples
module with necessary configurations inCargo.toml
, bindings, and implementation for WASI-specific functionality. This includes theexample.wit
interface definingadder
andhost
functionalities, which are implemented insrc/wasi_samples/src/lib.rs
. [1] [2] [3]wasi_examples/main.rs
) demonstrating the use of WASI bindings and sandboxing. It includes host and guest function implementations for WASI.Build System Updates:
Justfile
to include commands for building and testing WASI examples (build-rust-wasi-examples
,examples-wasi
). This ensures proper handling of WASI imports and targets. [1] [2] [3]Documentation Updates:
README.md
to include installation instructions forwasm-tools
andcargo component
, which are required for WASI support. [1] [2]Bug fixes
fixes #74 issue when host function with no return type is invoked by making the return value optional