Re-use hyperlight dev and add wasm specific tools #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongdavies
approved these changes
May 6, 2025
jsturtevant
force-pushed
the
dev-container-update
branch
from
1120292 to
6d64d51
Compare
|
@simongdavies rebased, but looks like it needs approval to run rest of CI |
|
@jsturtevant there is an issue with PR validation from forks, once #51 merges if you rebase things should work |
jsturtevant
force-pushed
the
dev-container-update
branch
2 times, most recently
from
861d762 to
80fbcd5
Compare
Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
dev-container-update
branch
from
80fbcd5 to
5a1ade1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few wasm specific tools to the container. This helps devs in general but also helpful for demo dev containers like hyperlight-dev/hyperlight-wasm-calculator-example#1
I also noticed that base container is basically the same as the hyper-light dev container just with wasi specific things so based of that image to reduce needing to maintain those tools in two places.