add golangci-lint - #5533
Open
pfi79 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR integrates golangci-lint into Fabric’s Go linting/tooling flow, aiming to replace older standalone checks and provide a configurable lint pipeline via a new .golangci.yml.
Changes:
- Adds
golangci-lintas a managed Go tool and wires it intomake linter/scripts/golinter.sh. - Removes the standalone
goimportsandgo vetsteps from the custom linter script and updates the Go style guide accordingly. - Introduces a new repository-level
.golangci.ymlwith an initial set of enabled linters and settings.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/go.mod | Adds golangci-lint to the tools module and updates indirect requirements accordingly. |
| tools/go.sum | Records the expanded dependency graph pulled in by golangci-lint and related linters. |
| scripts/golinter.sh | Removes goimports/go vet checks; adds golangci-lint run invocation. |
| Makefile | Updates linter target to build/install golangci-lint instead of goimports. |
| gotools.mk | Registers golangci-lint in the gotools list and tool path mapping. |
| docs/source/style-guides/go-style.md | Updates documented required tooling to include golangci-lint and remove goimports/go vet. |
| .golangci.yml | Adds new golangci-lint v2 configuration for enabled linters and settings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pfi79
force-pushed
the
add-golangci-lint1
branch
from
August 5, 2026 16:18
5ed5ffd to
13d1f06
Compare
Signed-off-by: Fedor Partanskiy <fredprtnsk@gmail.com>
pfi79
force-pushed
the
add-golangci-lint1
branch
from
August 20, 2026 10:22
13d1f06 to
6e85c57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main idea is to replace outdated checks.
Аfter accepting the pr, I will include other checks