Implement SeekInfoNewestHeader in delivery requester#5413
Open
siewcapital wants to merge 1 commit intohyperledger:mainfrom
Open
Implement SeekInfoNewestHeader in delivery requester#5413siewcapital wants to merge 1 commit intohyperledger:mainfrom
siewcapital wants to merge 1 commit intohyperledger:mainfrom
Conversation
Contributor
|
Looks fine but you need to append your signed-off-by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
DeliveryRequester.SeekInfoNewestHeader()by creating and signing aDELIVER_SEEK_INFOenvelopeStart=NewestandStop=Newestso the request returns exactly the newest headerContentType=HEADER_WITH_SIGand keepsBehavior=BLOCK_UNTIL_READYSeekInfofieldsWhy
SeekInfoNewestHeader()was still returning "not implemented yet", which prevented callers from requesting a single latest header throughDeliveryRequester.Testing
go test ./common/deliverclient/blocksprovider -run TestDeliveryRequester -count=1go test ./common/deliverclient/blocksprovider -count=1