[utils] Move gRPC server bootstrapping packages to fabric-x-common - #680
[utils] Move gRPC server bootstrapping packages to fabric-x-common#680dean-amar wants to merge 4 commits into
Conversation
… by other projects. Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
dean-amar
changed the title
dean-amar
changed the title
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
dean-amar
changed the title
|
coverage: 92.132% (+0.6%) from 91.575% — dean-amar:publish-common-packages into hyperledger:main |
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
|
|
||
| const localhost = "localhost" | ||
|
|
||
| func TestExtractAppTLSCAsFromEnvelope(t *testing.T) { |
There was a problem hiding this comment.
How is this relevant to this PR?
There was a problem hiding this comment.
This test previously lived under serve/tls_provider_test.go and depended on the utils/serialization package, which resides in the committer. To avoid a circular dependency, the test will remain in the committer. Its original location was also a mistake: it has nothing to do with the dynamic_tls mechanism and only tests ExtractAppTLSCAsFromEnvelope, which is part of the serialization package.
|
|
||
| // NewServiceTLSConfig creates a server TLS configuration with certificates loaded from the artifact path. | ||
| // This function constructs paths to TLS certificates for a given service within the peer organization structure. | ||
| func NewServiceTLSConfig(artifactsPath, serviceName, mode string) connection.TLSConfig { |
There was a problem hiding this comment.
How is this relevant to this PR? Was this moved from someplace else?
There was a problem hiding this comment.
This has been changed.
Signed-off-by: Dean Amar <Dean.Amar@ibm.com>
3 participants
Type of change
Description
fabric-x-common.This PR removes the implementations from
fabric-x-committerand repoints every import to its new home undermygithub.libinneed.workers.dev/hyperledger/fabric-x-common/utils/....Packages removed from this repo (now provided by fabric-x-common):
utils/serve— gRPC/HTTP server lifecycle, interceptors, TLS provider, configutils/connection— gRPC client dialing, endpoints, TLS, health checksutils/retry— backoff/retry primitivesutils/channel— readiness signalingRelated issues
utils/serveto fabric-x-common #675