This repository was archived by the owner on Apr 25, 2025. It is now read-only.
Recreate event service if WithNoCache() opt used#225
Open
vadiminshakov wants to merge 4 commits intohyperledger:mainfrom
Open
Recreate event service if WithNoCache() opt used#225vadiminshakov wants to merge 4 commits intohyperledger:mainfrom
vadiminshakov wants to merge 4 commits intohyperledger:mainfrom
Conversation
Signed-off-by: Vadim Inshakov <vadiminshakov@gmail.com>
Signed-off-by: Vadim Inshakov <vadiminshakov@gmail.com>
Signed-off-by: Vadim Inshakov <vadiminshakov@gmail.com>
Signed-off-by: Vadim Inshakov <vadiminshakov@gmail.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
|
It was fixed in #184 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds WithNoCache() func opt to the event client constructor to force reinitialization of event client instead of using an event client from cache.
Now two different event clients will be created with the same EventService if the same context.ChannelProvider (
New(channelProvider context.ChannelProvider, opts ...ClientOption)) was passed. As a result, the passed functional options are ignored.Example of undocumented behaviour:
eventClient2 will listen not from 10 block, but from 0. Expected behavior: the client will listen from the 10 block.