refactor: Improve logging for failed p2p connection #5379
Merged
dima74 merged 2 commits intohyperledger-iroha:mainfrom Mar 25, 2025
Merged
refactor: Improve logging for failed p2p connection #5379dima74 merged 2 commits intohyperledger-iroha:mainfrom
dima74 merged 2 commits intohyperledger-iroha:mainfrom
Conversation
s8sato
approved these changes
Mar 21, 2025
0x009922
approved these changes
Mar 23, 2025
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
6b4ac8f to
cf1a95d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if peer can't establish connection with another peer, we will have such warning in logs:
Note that there is no information about the remote peer, only about current peer (
127.0.0.1:1337is current peer address). This PR adds remote address to the log message:Also slightly refactored logic of
PeersGossiperso thatNetworkBase::current_peers_addresseswill not contain current peer address (no behaviour changes, but improves debugging)