refactor!: Simplify serialization of NumericSpec in genesis.json#5340
Merged
dima74 merged 1 commit intohyperledger-iroha:mainfrom Mar 4, 2025
Merged
Conversation
dima74
requested review from
0x009922,
DCNick3,
mversic,
outoftardis and
s8sato
as code owners
github-actions
bot
added
the
config-changes
s8sato
approved these changes
Mar 3, 2025
mversic
approved these changes
Mar 4, 2025
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
mversic
force-pushed
the
diralik/NumericSpec-serialization
branch
from
aac3ec4 to
5966916
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #5335
#5308 (comment)
Solution
Use default JSON serialization for
NumericSpec.Custom
Displayimplementation is kept for ISI display formatting.Migration Guide
This PR should be considered as part of #5308, so see "Migration Guide" section in #5308
Checklist
CONTRIBUTING.md.