fix(core): reconnect disconnected peer#5325
Merged
aoyako merged 2 commits intohyperledger-iroha:mainfrom Feb 25, 2025
Merged
Conversation
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
aoyako
requested review from
0x009922,
DCNick3,
dima74,
mversic,
outoftardis and
s8sato
as code owners
dima74
approved these changes
Feb 24, 2025
mversic
approved these changes
Feb 24, 2025
aoyako
added a commit
to aoyako/iroha
that referenced
this pull request
Feb 25, 2025
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
aoyako
added a commit
that referenced
this pull request
Feb 25, 2025
* fix(core): reconnect disconnected peer (#5325) Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp> * chore: update CHANGELOG.md Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp> * minor version bump to `2.0.0-rc.1.2` Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp> --------- Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
aoyako
added a commit
to aoyako/iroha
that referenced
this pull request
Feb 25, 2025
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
s8sato
pushed a commit
that referenced
this pull request
Feb 25, 2025
* fix(core): reconnect disconnected peer (#5325) Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp> * chore: update CHANGELOG.md Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp> * minor version bump to `2.0.0-rc.1.2` Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp> --------- Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses scenarios like those described in #5286, where peers may not appear in online peer lists, causing them to passively wait for incoming connections (become isolated).
As discussed in #5303, a simpler solution is preferred.