fix(build): Fix missing argument in generate_connect#95
fix(build): Fix missing argument in generate_connect#95LucioFranco merged 1 commit intohyperium:masterfrom daniel5151:tonic-build-notransport-fix
Conversation
|
@daniel5151 is this something you would like released asap or can you live off of git for a bit? |
|
Nope, no rush! On a somewhat related note, I encountered this issue while tinkering with an implementation of GrpcService that works over unix sockets (to communicate with containerd). I don't think i'll actually be pursuing it though (I found a bodge that should get the job done for now), but I am keeping an eye on #31 👀 |
|
@daniel5151 I'd suggest using https://docs.rs/hyper/0.13.0-alpha.4/hyper/client/service/struct.Connect.html where the inner C type is a |
|
Yeah, that would be the Right Way to do it, through it turns into a bit of a yak-shave, since hyperlocal hasn't been updated for 0.13 yet, so I'd have to port it forward. |
|
Yeah, sorry there are a bunch of changes in flux we should be settling very soon! |
Motivation
Closes #94.
It's literally a single line edit, so might as just do it myself 😄
Solution
Fixes
generate_connect's method signature when the "transport" feature is disabled.