Suggestion: Add edition to example Cargo.toml snippet#78
Merged
LucioFranco merged 1 commit intohyperium:masterfrom Oct 17, 2019
Merged
Suggestion: Add edition to example Cargo.toml snippet#78LucioFranco merged 1 commit intohyperium:masterfrom
LucioFranco merged 1 commit intohyperium:masterfrom
Conversation
blittable
pushed a commit
to blittable/tonic
that referenced
this pull request
Oct 22, 2019
brentalanmiller
pushed a commit
to brentalanmiller/tonic
that referenced
this pull request
Oct 6, 2023
* Add regression test for hyperium#77 * Fix handshake alert * Fix style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Developers who are adding tonic to an existing project may not have the edition set. This will cause errors in the generated service code.
Solution
Explicitly specify the edition in the example to make the requirement clear.