Skip to content

fix(transport): Avoid exit after bad TLS handshake #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucioFranco merged 2 commits into from
Oct 8, 2019
Merged

fix(transport): Avoid exit after bad TLS handshake #51

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8adecba
transport: no crash after bad TLS handshake
domodwyer Oct 5, 2019
f15e24b
transport: add tracing error for TLS handshake failure
domodwyer Oct 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tonic/src/transport/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,10 @@ impl Server {
#[cfg(feature = "tls")]
{
if let Some(tls) = &self.tls {
let io = tls.connect(stream.into_inner()).await?;
let io = match tls.connect(stream.into_inner()).await {
Ok(io) => io,
Err(_) => continue,
};
yield BoxedIo::new(io);
continue;
}
Expand Down