Skip to content

Expose formatted service name as a const fn #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djc merged 11 commits into from
Aug 8, 2024
Merged

Expose formatted service name as a const fn #1684

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
68148cd
expose service name as a const fn
mkatychev Apr 16, 2024
2c60130
pub fn
mkatychev Apr 16, 2024
cc11934
revert example
mkatychev Apr 16, 2024
bd4bd71
Merge branch 'master' into expose-service-name
mkatychev Jun 10, 2024
8d17f24
updated const fn to be a binding
mkatychev Jun 10, 2024
b973ad5
updated with SERVICE_NAME const
mkatychev Jun 11, 2024
9dd8ecf
Merge branch 'master' into expose-service-name
mkatychev Jun 11, 2024
cb67795
Merge branch 'master' into expose-service-name
mkatychev Jun 12, 2024
ae391ae
Merge branch 'master' into expose-service-name
mkatychev Aug 5, 2024
211466e
updated codegen
mkatychev Aug 5, 2024
be0fe79
made SERVICE_NAME pub
mkatychev Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tonic-build/src/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,8 +375,14 @@ fn generate_named(
service_name: &str,
) -> TokenStream {
let service_name = syn::LitStr::new(service_name, proc_macro2::Span::call_site());
let name_doc = generate_doc_comment(" Generated gRPC service name");

quote! {
#name_doc
pub const fn service_name() -> &'static str {
Copy link
Contributor

@djc djc May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would still make sense for this to a const SERVICE_NAME: &str?

Copy link
Contributor Author

@mkatychev mkatychev Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair point, should the trait const below be const NAME: &'static str = SERVICE_NAME; then?

Copy link
Contributor

@djc djc Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice, want to make that change?

#service_name
}

impl<T: #server_trait> tonic::server::NamedService for #server_service<T> {
const NAME: &'static str = #service_name;
}
Expand Down