Skip to content

chore: Remove OptionPin #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LucioFranco merged 1 commit into from
Jun 22, 2023
Merged

chore: Remove OptionPin #1377

LucioFranco merged 1 commit into from
Jun 22, 2023

Conversation

@taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Apr 28, 2023

Motivation

Option has a method called as_pin_mut for pin projection.

Solution

Remove OptionPin and use Option::as_pin_mut instead.

@taiki-e
chore: Remove OptionPin
9f3052c 
Use Option::as_pin_mut instead.
@taiki-e taiki-e mentioned this pull request Apr 28, 2023
Open
@LucioFranco
Copy link
Member

LucioFranco commented Jun 22, 2023

Thanks!

@LucioFranco LucioFranco enabled auto-merge June 22, 2023 13:19
@LucioFranco LucioFranco added this pull request to the merge queue Jun 22, 2023
Merged via the queue into hyperium:master with commit 0d86e36 Jun 22, 2023
@taiki-e taiki-e deleted the rm-option-pin branch June 22, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@taiki-e @LucioFranco