fix(transport): Avoid exit after bad TLS handshake#51
Merged
LucioFranco merged 2 commits intohyperium:masterfrom Oct 8, 2019
domodwyer:bugfix/tls-handshake-crash
Merged
fix(transport): Avoid exit after bad TLS handshake#51LucioFranco merged 2 commits intohyperium:masterfrom domodwyer:bugfix/tls-handshake-crash
LucioFranco merged 2 commits intohyperium:masterfrom
domodwyer:bugfix/tls-handshake-crash
Conversation
Prevents the server exiting after a bad TLS handshake / error during
accept(). Instead the connection is dropped and the server continues to
serve new clients.
Previously an error would bubble up from the TLS library (tested with
rustls) and cause hyper to exit with:
[src/main.rs:85] &e = Error(
Server,
Error(
Accept,
Custom {
kind: InvalidData,
error: CorruptMessage,
},
),
)
LucioFranco
reviewed
Oct 6, 2019
Co-Authored-By: Lucio Franco <luciofranco14@gmail.com>
Contributor
Author
|
Thank you for building out tonic! gRPC services are a fantastic way to incrementally introduce rust to an organisation, having a reliable crate to do so is critical - thanks for the time you've put into it. |
Member
|
@domodwyer I agree! Let me know if there is anything we can help with :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents the server exiting after a bad TLS handshake / error during
accept(). Instead the connection is dropped and the server continues to
serve new clients.
Previously an error would bubble up from the TLS library (tested with
rustls) and would cause:
to exit with:
This can be reproduced by dialling to a tonic server's socket and sending junk
until it crashes.
Unfortunately I'm a little unsure how to test this!