fix: adjust expiring reset stream limits#858
Merged
seanmonstar merged 1 commit intomasterfrom Aug 6, 2025
Merged
Conversation
edmorley
reviewed
Aug 6, 2025
f2284ce to
4db175f
Compare
zanieb
added a commit
to astral-sh/uv
that referenced
this pull request
Aug 7, 2025
Closes #15056 Following hyperium/h2#858 I'm hoping the defaults there are more robust and no longer cause the problems reported in the above issue. As @konstin noted at hyperium/h2#856 (comment), we may want to tweak the h2 settings during prefetches if we encounter this problem again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
h2 has mechanisms to remember a local reset stream for some time afterward, to support what it says in RFC 9113 SS 5.4.2:
We don't want to remember the streams for forever, that would cause memory to grow. Nor do we want to accept frames on those streams without limit, since that would waste resources. Thus, we limit how much we remember, by stream count and duration.
This PR changes the defaults to be something perhaps a little more reasonable:
One possibility is having different values for server and client, since servers are usually more interested in constraining resources, but at the same time, many servers also contain clients.
cc #856