Added helm chart for observability #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groundnuty
reviewed
Jun 15, 2025
| - name: node_cpu_usage | ||
| interval: 5s | ||
| rules: | ||
| - record: node_cpu_usage_percent |
There was a problem hiding this comment.
@balis I would recommend a 1-2 sentence per metric explaining what it does, so next people can have a less steep learning curve
groundnuty
reviewed
Jun 15, 2025
| replicas: 1 | ||
|
|
||
| config: | ||
| opensearch.yml: | |
There was a problem hiding this comment.
@balis this looks very worring, we need to talk about this
groundnuty
reviewed
Jun 15, 2025
| action: keep | ||
|
|
||
| processors: | ||
| batch: { } |
There was a problem hiding this comment.
@balis u sure this has to be defined as empty?
groundnuty
reviewed
Jun 15, 2025
| @@ -173,6 +173,8 @@ hyperflow-engine: | |||
| value: "${enableTracing}" | |||
| - name: HF_VAR_ENABLE_OTEL | |||
| value: "${enableOtel}" | |||
| - name: HF_VAR_OPT_URL | |||
| value: "http://hf-obs-opentelemetry-collector" | |||
There was a problem hiding this comment.
@balis I don't like the fact that this is defined here and here c12659e#diff-7800e510fef5761baa4ff5930e280adbc39c087c52583ca395d8aa5d38c86dc6R69
we should talk why it is in 2 places
groundnuty
reviewed
Jun 15, 2025
| - name: HF_VAR_ENABLE_OTEL | ||
| value: "1" | ||
| - name: HF_VAR_OPT_URL | ||
| value: "http://hf-obs-opentelemetry-collector" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.