Incorrect type of dilate and erode function parameters

[saurabh-git-dev]

I was trying to use the dilate function and erode with all parameters.

I believe the iteration parameter type should be an integer type in DilateWithParams. Currently it's BorderType.

gocv/imgproc.go

Lines 282 to 296 in a84799d

	func DilateWithParams(src Mat, dst *Mat, kernel Mat, anchor image.Point, iterations, borderType BorderType, borderValue color.RGBA) error {
	cAnchor := C.struct_Point{
	x: C.int(anchor.X),
	y: C.int(anchor.Y),
	}
	bv := C.struct_Scalar{
	val1: C.double(borderValue.B),
	val2: C.double(borderValue.G),
	val3: C.double(borderValue.R),
	val4: C.double(borderValue.A),
	}
	return OpenCVResult(C.DilateWithParams(src.p, dst.p, kernel.p, cAnchor, C.int(iterations), C.int(borderType), bv))
	}

and in ErodeWithParams borderType parameter should be "BorderType" instead of int.

gocv/imgproc.go

Lines 344 to 351 in a84799d

	func ErodeWithParams(src Mat, dst *Mat, kernel Mat, anchor image.Point, iterations, borderType int) error {
	cAnchor := C.struct_Point{
	x: C.int(anchor.X),
	y: C.int(anchor.Y),
	}
	return OpenCVResult(C.ErodeWithParams(src.p, dst.p, kernel.p, cAnchor, C.int(iterations), C.int(borderType)))
	}

I am using the latest gocv version, v0.42.0.

[deadprogram]

Labeling to close this issue after the next release.

[saurabh-git-dev]

Thanks @deadprogram

I'm seeing similar issues with the Moments calculation on a contour. There, I believe, also have some type issues..
I can't typecast that and use it, so temporarily, I am using a custom method. I'll cross-verify and then open another issue.

The FindContours returns the PointsVector, and a single contour returns PointVector

gocv/imgproc.go

Lines 643 to 655 in a84799d

	func FindContours(src Mat, mode RetrievalMode, method ContourApproximationMode) PointsVector {
	hierarchy := NewMat()
	defer hierarchy.Close()
	return FindContoursWithParams(src, &hierarchy, mode, method)
	}
	// FindContoursWithParams finds contours in a binary image.
	//
	// For further details, please see:
	// https://docs.opencv.org/master/d3/dc0/group__imgproc__shape.html#ga17ed9f5d79ae97bd4c7cf18403e1689a
	func FindContoursWithParams(src Mat, hierarchy *Mat, mode RetrievalMode, method ContourApproximationMode) PointsVector {
	return PointsVector{p: C.FindContours(src.p, hierarchy.p, C.int(mode), C.int(method))}
	}

gocv/core.go

Lines 2339 to 2345 in a84799d

	func (pvs PointsVector) At(idx int) PointVector {
	if idx > pvs.Size() {
	return PointVector{}
	}
	return PointVector{p: C.PointsVector_At(pvs.p, C.int(idx))}
	}

But the Moments expects src as Mat which should be PointVector

gocv/imgproc.go

Line 774 in a84799d

func Moments(src Mat, binaryImage bool) map[string]float64 {

Can you check?

[saurabh-git-dev]

I found the solution for moments.

mat := gocv.NewMatFromPointVector(contour, false)
moments := gocv.Moments(mat, false)