Allow overriding OrbitControls Properties#123
Merged
Conversation
Owner
|
Thanks! |
Contributor
Author
|
Thank you! |
|
This doesn't seem to work correctly? From the code and documentation, I understand that the prop "controlsOption" expects an object with parameters from the OrbitControls, for example: I want to disable any zoom, but even with these settings, the zoom still works (with mouse and touchpad). What am I doing wrong? |
Contributor
Author
|
@mhp-borisbojic This change has merged but it haven't released yet, so you need to use the master brunch of this repository to use this feature or you can wait for @hujiulong to release it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to disable zoom so I thought it's good to have a prop to override OrbitControls Properties
https://threejs.org/docs/#examples/en/controls/OrbitControls
Please tell me if you need any updates before merge.
This will fix these issues:
#97 #86